Skip to content

[Bug] Prevent bubbling of the file upload cancelation - #672

Open
julien-nc wants to merge 1 commit into
mainfrom
fix/656/prevent-cancel-upload-bubbling
Open

julien-nc wants to merge 1 commit into
mainfrom
fix/656/prevent-cancel-upload-bubbling

Conversation

@julien-nc

Copy link
Copy Markdown
Member

closes #656

In the chat UI. It was closing the assistant.

How to reproduce the issue

  • Open the assistant's chat UI
  • Click the + button and select Upload from device
  • Close the file upload browser native dialog

It used to close the assistant because the "cancel" event bubbled up and was caught in assistant.js which was closing the entire assistant dialog.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

…it was closing the assistant

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc added bug Something isn't working 3. to review priority high javascript Pull requests that update javascript code labels Sep 28, 2026
@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b2af3f78-2176-4bc7-b6a5-d6e4034aca16

📥 Commits

Reviewing files that changed from the base of the PR and between 2ead20d and 50db3f6.

📒 Files selected for processing (1)
  • src/components/ChattyLLM/InputArea.vue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working javascript Pull requests that update javascript code priority high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancelling a file upload in Nextcloud Assistant closes the Assistant window

1 participant