Repository navigation
Conversation
Collaborator
|
As discussed offline, esmeralda and beersheba corrections are the "official" ones, so we want to enforce them. sophronia corrections are the optional ones and serve monitoring and early-analysis purposes. Recorrecting sophronia hits in esmeralda has no effect, provided that the same map is used and the hits have not been altered. For the specific use case that triggered this PR, the optional corrections functionality will remain in a separate branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The esmeralda city currently requires a correction map rather than taking it as an option. This PR fixes this.