Skip to content

Fix storage of sophronia events with 0 S2s - #985

Merged
gonzaponte merged 2 commits into
next-exp:masterfrom
gonzaponte:sophronia-0S2
Nov 5, 2026
Merged

gonzaponte merged 2 commits into
next-exp:masterfrom
gonzaponte:sophronia-0S2

Conversation

@gonzaponte

Copy link
Copy Markdown
Collaborator

The functionality to fix default values was broken for S2s. This PR fixes it.

@Ian0sborne
Ian0sborne self-requested a review October 30, 2026 13:52

@Ian0sborne Ian0sborne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR ensures that all S2-related fields are filled in when nS2 = 0 allowing those events to be stored as kDSTs. Good work!

@gonzaponte
gonzaponte merged commit 3e8881e into next-exp:master Nov 5, 2026
1 check passed
@gonzaponte
gonzaponte deleted the sophronia-0S2 branch November 5, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants