Repository navigation
Fix storage of sophronia events with 0 S2s - #985
Merged
Merged
Conversation
Ian0sborne
self-requested a review
October 30, 2026 13:52
Ian0sborne
approved these changes
Nov 5, 2026
Ian0sborne
left a comment
Contributor
There was a problem hiding this comment.
This PR ensures that all S2-related fields are filled in when nS2 = 0 allowing those events to be stored as kDSTs. Good work!
gonzaponte
force-pushed
the
sophronia-0S2
branch
from
November 5, 2026 14:34
3e5e320 to
496a2f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionality to fix default values was broken for S2s. This PR fixes it.