Skip to content

Address pyflakes' complains - #978

Merged
gonzaponte merged 7 commits into
next-exp:masterfrom
gonzaponte:pyflakes
Nov 6, 2026
Merged

gonzaponte merged 7 commits into
next-exp:masterfrom
gonzaponte:pyflakes

Conversation

@gonzaponte

Copy link
Copy Markdown
Collaborator

This PR fixes the complains raised by pyflakes in the repo.

@jwaiton jwaiton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR that resolves a lot of small issues!

Just one small comment on format.

Comment on lines -559 to -563
f = quick_gauss_fit(df['Ec'].values, bins_Ec, sigma = error)
_, mu, sigma = f.values
_, u_mu, u_sigma = f.errors

chi2_ec_prelim = f.chi2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_time_evol_single_slice() now appears a bit strange, as later in the function almost the exact same procedure is followed, but using underscore notation.

Perhaps:

_, mu,   _ = f.values
_, u_mu, _ = f.erors

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jwaiton jwaiton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR resolves some small issues related to pyflakes, as well as some minor cosmetic issues and bugs. Approved! Good work!

@gonzaponte
gonzaponte merged commit 43b8fca into next-exp:master Nov 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants