[mazarijuraj]

Description

Fixes NAE-2484 following implementation in NAB-400

Summary by CodeRabbit

• Bug Fixes
  • The change-data dialog now lets you edit each value separately and shows validation feedback for the corresponding value.
  • Saving is unavailable while any value is invalid. When saved, each updated value remains associated with its original data entry.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: f4509ffb-edc9-4305-84ea-dedb542bc0f8

📥 Commits

Reviewing files that changed from the base of the PR and between 99755f3 and db05f3d.

📒 Files selected for processing: 2

• projects/netgrif-components/src/lib/builder/dialogs/dialog-change-data/dialog-change-data.component.html
• projects/netgrif-components/src/lib/builder/dialogs/dialog-change-data/dialog-change-data.component.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The change-data dialog now uses one validated form control for each data-set value. On save, it returns the original IDs with the corresponding edited values.

Changes

Change-data dialog

Layer / File(s)	Summary
Indexed controls and save result projects/netgrif-components/src/lib/builder/dialogs/dialog-change-data/dialog-change-data.component.ts, projects/netgrif-components/src/lib/builder/dialogs/dialog-change-data/dialog-change-data.component.html	The component creates a validated control for each data-set value. The template binds each field to its indexed control and disables save when the form array is invalid. Saving returns each data-set item’s ID with its edited value.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to db05f

The dialog preserves each edited value with its original ID, and no issue remains that should block merging.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the change to the Change Data dialog FormControl and includes the related issue key.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud