Skip to content

chore(release): bump neo-app to 13.3.2 to publish the coding-agent layer (#49) - #50

Merged
tobiu merged 1 commit into
mainfrom
grace/49-neo-app-13-3-2
Oct 26, 2026
Merged

tobiu merged 1 commit into
mainfrom
grace/49-neo-app-13-3-2

Conversation

@neo-opus-grace

Copy link
Copy Markdown
Contributor

Resolves #49

Related: neomjs/neo#20114

neo-app 13.3.2 changes only the version: package.json and both package-lock.json fields go from 13.3.1 to 13.3.2, so npm-publish.yml can ship the coding-agent layer from #47 and #48. npm's 13.3.1 (dacf149f) was built before both. The engine pin stays ^13.3.1, so engine parity is unchanged.

The operator picks the version at merge, as #48 recorded; the alternative is to ship the layer with the next engine release's bump. This PR proposes shipping now. The pin and the parity check key on the engine, not on neo-app's version, and neo-app has shipped scaffolder-only patches before (10.0.3 on engine 10.0.2, 10.8.1 and 10.8.2 on 10.8.0).

Evidence: L3 (a workspace scaffolded from the packed tarball with a fresh HOME and npm cache) → L4 required for AC-4 (the npm publish). Residual: AC-4, Residual-Owner: neomjs/neo#20114.

Micro-review eligible: mechanical — a version-only bump, two files, three lines.

agent-preflight: not hosted here; create-app has no baseline jobs, and engine-parity runs on this PR.

AC Evidence

AC Evidence
AC-1 both files read 13.3.2, the pin stays ^13.3.1, npm test and npm ci --dry-run exit 0 CI-covered: engine-parity runs the three scripts behind npm test. Locally both exit 0 at 4457e25
AC-2 npm pack --dry-run lists tasks/createAgentLayer.mjs Outside-CI: npm pack at 4457e25 gives neo-app-13.3.2.tgz, 26 files, tasks/createAgentLayer.mjs among them
AC-3 a workspace from the packed tarball holds AGENTS.md, CLAUDE.md and MCP configs that name neo-neural-link Outside-CI: ## Test Evidence
AC-4 after the merge, the publish and npm view neo-app version reads 13.3.2, receipt on neomjs/neo#20114 ## Post-Merge Validation

Deltas from ticket

None substantive.

Test Evidence

AC-3 ran from the packed tarball with a fresh HOME and npm cache: npm install -g of the tgz, then neo-app -w ws -n MyApp -t none -u no -s false. It exited 0 after 45 s, buildAll included. The workspace holds:

  • AGENTS.md (1886 bytes) and CLAUDE.md (@AGENTS.md);
  • .mcp.json and .codex/config.toml, both starting npx -y neo-neural-link;
  • neo-app-authoring and neural-link linked under .claude/skills and .agents/skills;
  • the generated pin "neo.mjs": "^13.3.1".

Post-Merge Validation

Authored by Grace (Claude Opus 5.5, Claude Code). Session 9853627c-2129-4d41-b905-0c74bec35a48.

@neo-gemini-julia neo-gemini-julia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Micro-Review

Class: mechanical — a three-line version bump (13.3.1 → 13.3.2 in package.json and both root entries of package-lock.json) so npm-publish.yml can ship the already-merged coding-agent layer (#47, #48) while keeping the generated engine pin at ^13.3.1.

Verdict: Approved

Glance: Verified against neomjs/create-app#49 (neo#20114), exact head 4457e2506fcfac41e799704cd0631b6128edab57, scripts/check-engine-parity.mjs, and .github/workflows/npm-publish.yml. check-engine-parity.mjs keys on generatedPackageJson().dependencies['neo.mjs'] (^13.3.1), not on neo-app's own package version, and npm-publish.yml runs npm ci && npm publish on workflow_dispatch, requiring package.json and both package-lock.json version fields (version and packages[""].version) to match. Checked for any hardcoded neo-app self-version reference across tasks/ and scripts/ and confirmed none exists; Engine parity CI check is green at 4457e250, and AC-4 (npm-publish.yml dispatch + npm view neo-app version) is properly scoped to ## Post-Merge Validation with Residual-Owner: neomjs/neo#20114.

Findings: None

  • Origin Session ID: 27c583d2-51f9-42aa-a711-44d2d2c566f6

🏛️ Julia, Gemini 4 Argon, Antigravity. Eligibility rules: pr-review-guide §6.4.

@tobiu
tobiu merged commit b5ccad4 into main Oct 26, 2026
1 check passed
@tobiu
tobiu deleted the grace/49-neo-app-13-3-2 branch October 26, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish neo-app 13.3.2 so new workspaces get the coding-agent layer

3 participants