Fixed Ctrl++/− zoom shortcuts not working with the numpad +/− keys - #165
Merged
Conversation
Bound VK_ADD/VK_SUBTRACT/VK_NUMPAD0 alongside the existing main-keyboard VK_EQUALS/VK_MINUS/VK_0 in ZoomSupport.bindZoomKeys() (used by Markdown Preview and the terminal tab's Swing InputMap) and in ClaudeSessionTab.zoomKeyInterceptor (the global KeyEventDispatcher needed because JediTerm consumes key events before Swing's InputMap sees them). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-/=keys (VK_MINUS/VK_EQUALS); the numpad+/-keys (VK_ADD/VK_SUBTRACT) were never wired up in either the terminal tab or Markdown Preview.VK_ADD/VK_SUBTRACT/VK_NUMPAD0alongside the existing keys inZoomSupport.bindZoomKeys()and inClaudeSessionTab.zoomKeyInterceptor(the globalKeyEventDispatcherneeded because JediTerm consumes key events before Swing's InputMap sees them).Test plan
mvn test— all tests pass, including newZoomSupportTest.bindZoomKeys_registersNumpadPlusMinusAndZeroInBothMapsandClaudeSessionTabZoomKeyTestmvn packagesucceedsCtrl+NumpadPlus/Ctrl+NumpadMinus/Ctrl+Numpad0— zoom in/out/reset. Repeat in Markdown Preview. Verify main-keyboardCtrl+=/Ctrl+-/Ctrl+0still work (no regression).🤖 Generated with Claude Code