Fixed a "Warning" dialog with raw XML content sometimes appearing at IDE startup after using a diff view - #161
Merged
oleg68 merged 1 commit intoJul 14, 2026
Conversation
…IDE startup after using a diff view OpenDiff.java's diff-viewer TopComponent didn't override getPersistenceType(), so it defaulted to PERSISTENCE_ALWAYS. NetBeans would then try to persist this ephemeral tab (and the non-serializable async-handler state its toolbar listeners closed over) to a .settings file on IDE exit, which failed to deserialize on the next startup and surfaced as a raw-XML warning dialog. Extracted the anonymous TopComponent into a named OpenDiff.DiffTopComponent that overrides getPersistenceType() to PERSISTENCE_NEVER, matching the existing correct pattern in FileDiffOpener.DiffTopComponent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopComponentinOpenDiff.javadidn't overridegetPersistenceType(), defaulting toPERSISTENCE_ALWAYS.settingsfile on exit, which failed to deserialize on next startup and surfaced as a "Warning" dialog dumping raw XMLOpenDiff.DiffTopComponentoverridinggetPersistenceType()toPERSISTENCE_NEVER, matching the existing correct pattern inFileDiffOpener.DiffTopComponentTest plan
OpenDiffTest.diffTopComponentPersistenceTypeIsNeverasserting the persistence typemvn test— full suite passesmvn package— builds successfully.settings/.wstcrefentries from before the fix, the warning dialog no longer appears at startup🤖 Generated with Claude Code