Repository navigation
Do not take supertype type arguments for JDK value types and enums - #1397
Merged
Merged
Conversation
- Infer no type arguments for JDK classes without type parameters, such as String - Infer no type arguments for enums, instead of Enum<E>'s
github-actions
Bot
requested review from
SooKim1110,
acktsap,
benelog,
jwChung and
mhyeon-lee
November 19, 2026 07:29
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenericTypeResolverConverterinferred the type arguments of a set value's elements from their supertypes when the element class had none of its own. AStringelement gotString<String>fromComparable<String>, and an enum elementColor<Color>fromEnum<Color>. This PR gives JDK classes without type parameters and enums no type arguments.This is the first of four stacked PRs:
(Optional): Description
GenericTypeResolverConverter.extractTypeArgumentsFromValuereturns no type arguments for:String,Integer,BigDecimalorLocalDate. Their parameterized supertypes, such asComparable<String>, describe the supertype, not the value.Enum<E>Supplier<String>, whose element type comes from them.OptionalandMap.Entry: anOptionalholding aStringwould becomeOptional<String<String>>.How Has This Been Tested?
GenericTypeResolverConverterTest: a collection ofStrings and a collection of enums are inferred asStringand as the enum class, without type argumentsobject-farm-api,fixture-monkey,fixture-monkey-kotlin,java-tests,java-17-testsandkotlin-testswith checkstyle, Checker Framework and ktlintIs the Document updated?
No documentation change is needed.