Repository navigation
Add Lua.pushExternalString - #237
Merged
Merged
Conversation
Only for Lua 5.5. External strings are not owned by Lua.
Owner
Author
|
@robbielyman I think this one is pretty straightforward. Any thoughts before I merge? |
Collaborator
|
Looks good to me! One question I had: since the Lua 5.5 function takes a length parameter, would it be better to allow |
Owner
Author
|
The reference manual mentions the string should have a zero at the end, so I think Lua requires it to be null terminated for some reason |
Collaborator
|
Ahh ok. I guess it is true that If that's the case, it looks good to merge to me! I just notice the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235