Skip to content

CMR-11502: Cleaning up non needed elements and files. - #2534

Merged
eereiter merged 1 commit into
masterfrom
CMR-11502-1
Nov 4, 2026
Merged

eereiter merged 1 commit into
masterfrom
CMR-11502-1

Conversation

@eereiter

@eereiter eereiter commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Overview

What is the objective?

GIBS wanted some non needed elements deleted in schema.json and also to delete the tiles/definition.json file.

What are the changes?

deleted all ows: and mwts: prefix named elements in schema.json and also to delete the tiles/definition.json file.

What areas of the application does this impact?

UMM-Vis schema version 1.2.0

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings

Additional Checklist

  • I have removed unnecessary/dead code and imports in files I have changed
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • reduced number of system state resets by updating fixtures. Ex) (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@codecov-commenter

codecov-commenter commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.41%. Comparing base (85e0c9b) to head (6a544b4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2534      +/-   ##
==========================================
- Coverage   54.41%   54.41%   -0.01%     
==========================================
  Files        1047     1047              
  Lines       73542    73542              
  Branches     2412     2410       -2     
==========================================
- Hits        40018    40016       -2     
- Misses      31248    31249       +1     
- Partials     2276     2277       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eereiter
eereiter merged commit cc5a76c into master Nov 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants