Skip to content

fix(test): Fix hunk filtering on MacOS and update covbadge - #213

Merged
BakerNet merged 2 commits into
mainfrom
fix/test-should-be-runnable-macos
Oct 1, 2026
Merged

BakerNet merged 2 commits into
mainfrom
fix/test-should-be-runnable-macos

Conversation

@BakerNet

@BakerNet BakerNet commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Covbadge is out of date on main and hunk filtering breaks on MacOS

@github-actions
github-actions Bot requested a review from zbedforrest October 1, 2026 21:08
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codeowners approval required for this PR:

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Fixes symlink resolution in the hunk filtering logic.

The PR appears safe to merge based on the changes since the previous review.

Summary

The app now resolves symlinks in the longest existing part of a hook path, so missing paths keep the canonical path of their parent folders. The README coverage badge changes from 83.6% to 83.7%.

  • Hook paths with missing final files keep symlinks from their existing parents.
  • The README shows the updated coverage figure.

Reviews (2) · Last reviewed commit: "Merge branch 'main' into fix/test-should..."

@asyncawaitpromise asyncawaitpromise left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BakerNet
BakerNet merged commit 5b7e913 into main Oct 1, 2026
10 of 11 checks passed
@BakerNet
BakerNet deleted the fix/test-should-be-runnable-macos branch October 1, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants