Repository navigation
fix: manual entries and timeline filters ignored JSON fields - #306
Merged
Merged
Conversation
"Manual entry" failed with HTTP 500 (NOT NULL constraint on start), and
exporting a timeline ignored its project and client filters, ever since
the frontend sends JSON (Vue migration).
Both endpoints take no method arguments and checked their fields with
isset($this->request->...). Nextcloud's magic isset() only sees form and
URL parameters; JSON body fields are only visible through getParam()
(endpoints with arguments like update-work-interval/{id} work, because
the dispatcher reads those through getParam() first).
Read the fields with getParam() in addWorkInterval and postTimeline.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015KJpM1wJdw3Uxw5p86uRBD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Manual entry" failed with HTTP 500 (NOT NULL constraint on start), and exporting a timeline ignored its project and client filters, ever since the frontend sends JSON (Vue migration).
Both endpoints take no method arguments and checked their fields with isset($this->request->...). Nextcloud's magic isset() only sees form and URL parameters; JSON body fields are only visible through getParam() (endpoints with arguments like update-work-interval/{id} work, because the dispatcher reads those through getParam() first).
Read the fields with getParam() in addWorkInterval and postTimeline.
Fixes #305