Skip to content

fix: manual entries and timeline filters ignored JSON fields - #306

Merged
Martin-1997 merged 1 commit into
masterfrom
fix/manual-entry-json
Nov 11, 2026
Merged

Martin-1997 merged 1 commit into
masterfrom
fix/manual-entry-json

Conversation

@Martin-1997

Copy link
Copy Markdown
Collaborator

"Manual entry" failed with HTTP 500 (NOT NULL constraint on start), and exporting a timeline ignored its project and client filters, ever since the frontend sends JSON (Vue migration).

Both endpoints take no method arguments and checked their fields with isset($this->request->...). Nextcloud's magic isset() only sees form and URL parameters; JSON body fields are only visible through getParam() (endpoints with arguments like update-work-interval/{id} work, because the dispatcher reads those through getParam() first).

Read the fields with getParam() in addWorkInterval and postTimeline.

Fixes #305

"Manual entry" failed with HTTP 500 (NOT NULL constraint on start), and
exporting a timeline ignored its project and client filters, ever since
the frontend sends JSON (Vue migration).

Both endpoints take no method arguments and checked their fields with
isset($this->request->...). Nextcloud's magic isset() only sees form and
URL parameters; JSON body fields are only visible through getParam()
(endpoints with arguments like update-work-interval/{id} work, because
the dispatcher reads those through getParam() first).

Read the fields with getParam() in addWorkInterval and postTimeline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015KJpM1wJdw3Uxw5p86uRBD
@Martin-1997
Martin-1997 merged commit 774ebfa into master Nov 11, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manual entries fail and timeline filters are ignored when data is sent as JSON

1 participant