Repository navigation
Update to nextcloud 35 - #287
Merged
Merged
Conversation
The frontend was migrated to @nextcloud/vue 9 in #263, which only supports Nextcloud 31 and newer (Vue 3). Declaring min-version="20" let the app install on servers whose UI it cannot render. Nextcloud 31 is also the oldest version whose OCP API provides everything the backend uses after the following commits (IDBConnection::getDatabaseProvider, IQueryBuilder::executeQuery). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015KJpM1wJdw3Uxw5p86uRBD
- Application: drop the hand-registered WorkIntervalMapper and ReportItemMapper services. Nothing requested them by these names (the mappers are autowired), and they relied on IServerContainer::getDatabaseConnection() and on getContainer() returning an IAppContainer, which Nextcloud 35 types as a plain PSR ContainerInterface. Also remove unused imports. - AjaxController: inject IMailer instead of \OC::$server->getMailer(), which no longer exists (e-mailing a timeline failed with "Call to undefined method OC\Server::getMailer()"). - AjaxController: use IGroupManager::isAdmin() instead of the private \OC_User class, and request "userId" instead of the deprecated "UserId" container alias. - Migration Version000000Date20210719124731: use executeQuery() / executeStatement() instead of the removed IQueryBuilder::execute(). Installs that still had the pre-2021 tables crashed on upgrade. - TagMapper, ReportItemMapper: detect the database with getDatabaseProvider() instead of matching Doctrine platform class names, and declare TagMapper::$dbengine (dynamic property). - phpstan baseline: drop the entries these changes resolve. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015KJpM1wJdw3Uxw5p86uRBD
- info.xml: max-version 35 - Static analysis runs against the OCP stubs of Nextcloud 31 and 35, the oldest and newest supported versions - PHP lint and unit tests run on PHP 8.2 to 8.5 (Nextcloud 35 needs PHP 8.3+, 8.5 is recommended) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015KJpM1wJdw3Uxw5p86uRBD
|
This relase is not visible yet in the app store. Does it still need to be pushed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.