Repository navigation
fix: correct pagination and mock response boundaries - #110
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mstuart
marked this pull request as draft
October 26, 2026 23:50
mstuart
marked this pull request as ready for review
October 26, 2026 23:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honor supplied offset/skip values, reject invalid pagination bounds, and stop Relay cursor cycles while preserving hasMore for incomplete retrieval. Parse mock query aliases correctly, reject invalid mock generation bounds, and preserve own prototype-named fields in summarized JSON.
Validation: 160 tests, typecheck, build, Ultracite check, and all required coverage thresholds passed (83.09% lines, 72.16% branches). Six regression cases failed against main; offset and skip now have separate cases. The max-pages fixture uses distinct cursors so it exercises the page limit independently of cycle detection.