Skip to content

build with node 17.x - #59

Closed
js-seth-h wants to merge 1 commit into
msgpack:masterfrom
js-seth-h:master
Closed

js-seth-h wants to merge 1 commit into
msgpack:masterfrom
js-seth-h:master

Conversation

@js-seth-h

Copy link
Copy Markdown

it change c++ version to c++14.

@blackdynamo

Copy link
Copy Markdown

This also works with the latest node 16 for other people who have issues. Can confirm this fixes the build issues I was having. I was going to put together the same PR.

@js-seth-h one thing to note is that you committed a yarn.lock file.

@ahmads-dy

Copy link
Copy Markdown

Can an admin approve this PR please?

@enochgroot

Copy link
Copy Markdown
Collaborator

Superseded by 2.0.0 (#25687, e04c9b5). The package now requires Node.js 18+ (engines.node: ">=18"), so a Node 17 / C++14 / yarn.lock change is no longer needed.

@enochgroot

Copy link
Copy Markdown
Collaborator

Re-evaluated on master e04c9b55 (2.0.0), Node v20.20.2.

  • engines.node is >=18
  • CI matrix is Node 18/20/22 on Ubuntu, macOS, and Windows 2022
  • binding.gyp does not pin -std=c++11 or -std=c++14
  • npm install && npm test on this tree: 128 pass, 0 fail

Node 17 is outside the supported range. Closing this PR as superseded by 2.0.0.

@enochgroot enochgroot closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants