msgpack stream write 'drain'?

[llint]

In the Stream wrapper of msgpack.js, it seems that the send function doesn't handle the underlying stream's writable.'drain' event, even though in most cases, stream.write would succeed, but for high volume data pumping scenarios, when stream.write returns false, the writable.'drain' event should be used to resume writing

[enochgroot]

Stream.send() already returns the boolean from the underlying write() (lib/msgpack.js in 2.0.0 / #25687). Callers that see false can wait for 'drain' on the wrapped stream. Adding drain handling inside Stream would be a new API, not a 2.0.0 bug.

[enochgroot]

Re-evaluated on master e04c9b55. Stream.send returns s.write.apply(...) (the writable's boolean). Repro: ms.send({a:1}) returned true (typeof boolean).

Node's contract is: when write() returns false, wait for drain on that writable. Stream does not buffer internally or re-emit drain. Automatic buffering would be a new API. Leaving open.