Conversation
Comment on lines
+41
to
+51
| const res = await fetch(url, { cache: "no-store" }); | ||
| if (!res.ok) { | ||
| throw new HackbotError( | ||
| `Could not read ${artifactName} (${res.status})`, | ||
| res.status | ||
| ); | ||
| } | ||
| const buf = await res.arrayBuffer(); | ||
| const truncated = buf.byteLength > RAW_MAX_BYTES; | ||
| const text = new TextDecoder().decode(buf.slice(0, RAW_MAX_BYTES)); | ||
| return NextResponse.json({ text, truncated }); |
Member
There was a problem hiding this comment.
Why are we doing this here instead of on the client side? The redirect approach makes it free for us since the artifacts are served from GCS directly instead of us processing it in the middle.
Contributor
Author
There was a problem hiding this comment.
This requires setting a CORS policy on the results bucket
Contributor
Author
There was a problem hiding this comment.
Either way works for me. All this code is expendable.
evgenyrp
force-pushed
the
build-repair-patch-panel-ui
branch
from
September 15, 2026 22:42
b49098a to
5eab40f
Compare
evgenyrp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The panel looks like this. I dropped the description because the agent doesn't commit the changes by design now. It will be a part of the Phabricator action.
