Skip to content

dns ca: escalate itself for the system store, like dns enable; never advise sudo moshcode #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Sep 17, 2026
+21 −3
Merged

dns ca: escalate itself for the system store, like dns enable; never advise sudo moshcode #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/cli-schema.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,8 @@ export const DNS_VERBS = [
name: "ca",
description: "trust the registry's root here, so every Moshpit name is trusted at once",
synopsis: [
["moshcode dns ca", "fetch the registry's root, check it, install it (NSS without root, the system store with sudo)"],
["moshcode dns ca", "fetch the registry's root, check it, install it everywhere (asks for sudo for the system store)"],
["moshcode dns ca --user-only", "the browser store only; no prompt"],
["moshcode dns ca --remove", "take it back out of every store"],
],
},
Expand Down
17 changes: 17 additions & 0 deletions src/dns.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2625,6 +2625,23 @@ export async function dnsCommand(args = [], out = console.log, deps = {}) {
// bridge, DoH in the browser, TronBrowser's own resolver) but its clients
// still refuse the certificates. `--remove` takes it back out.
if (sub === "ca") {
// Half of this needs root (the system store) and half must not run as
// root's own user (the operator's NSS database), which is exactly the
// shape `dns enable` already handles: escalate this one command, and let
// operatorHome() find the person behind sudo. `sudo moshcode dns ca` from
// a shell is what bonita hit: moshcode lives in the operator's PATH, not
// root's, so "command not found". Escalating from inside carries the path.
// --user-only keeps it to the browser store, no prompt, for a machine
// where sudo is not on offer.
if (uid !== 0 && !rest.includes("--user-only")) {
const escalated = escalate({
args: ["dns", "ca", ...rest],
what: "dns ca",
out,
});
if (escalated.ran) return escalated.code;
out("(no sudo here — installing into the browser store only; the system store needs root)");
}
if (rest.includes("--remove")) {
const r = await removeRegistryTrust(out, deps);
return r.ok ? 0 : 1;
Expand Down
4 changes: 2 additions & 2 deletions src/trust.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,7 @@ export async function applyRegistryTrust(out, deps = {}) {
}
for (const step of plan.skipped) {
out(` -- ${step.label} — ${step.why}`);
if (step.needsRoot) out(" re-run with root to cover it: sudo moshcode dns ca");
if (step.needsRoot) out(" run `moshcode dns ca` from a terminal to cover it — it asks for sudo itself");
}
return { ok: true, installed, skipped: plan.skipped.length, file };
}
Expand Down Expand Up @@ -1225,7 +1225,7 @@ export async function removeRegistryTrust(out, deps = {}) {
if (haveFile) await runner("rm", ["-f", file]);
for (const step of plan.skipped) {
out(` -- ${step.label} — ${step.why}`);
if (step.needsRoot && uid !== 0) out(" re-run with root to cover it: sudo moshcode dns ca --remove");
if (step.needsRoot && uid !== 0) out(" run `moshcode dns ca --remove` from a terminal to cover it — it asks for sudo itself");
}
return { ok: true, removed, skipped: plan.skipped.length };
}
Loading