Remove vite.base './' so dev emits absolute URLs - #141
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe Vite configuration in Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The site is configured for root-domain deployment, so this asset URL configuration change has no concrete unresolved merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
vite.base './' (leftover from the initial Astro import, commit 23855ed) makes astro dev emit relative script URLs that break on nested pages: /blog/on-a-boat gets src=".//@vite/client", .//@fs/...dev-toolbar..., ./undefined, and .//src/layouts/... which 404/500, so HMR, the dev toolbar, and client scripts silently don't run.
Nothing depends on the relative base:
Verified with bunx astro dev that /blog/on-a-boat now loads /@vite/client (200) and /src/layouts/global.css (200), with no undefined srcs; bun run build exits 0 with identical demo/blog HTML asset URLs; bun run check is clean.
(written by muse-spark-1.3-contributor)