Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed on master (stable
check): with moon 0.1.20261012 / moonc v0.10.15moon fmt+git diff --exit-codefails: the formatter now rewritesInttoInt32andUInttoUInt32(new builtin aliases).moon check --deny-warnfails: the parsers generated bymoonbitlang/yacccall@list.empty(), which the bundled core now deprecates in favour ofList([]).What changed:
moon fmtat the workspace root), 78 files. This part is byte-for-byte the tree of promote #207 (promote-20261012), so the two do not conflict; this PR is promote #207 plus the item below.warningsgets-20(deprecated) in the three packages that contain a generated parser:attribute,mbti_parser,yacc_parser.For review (left open on purpose):
-20suppression is a stopgap. The deprecated call is in the generator's own output (runtime and its standard-library rules), not in the.mbtysources, andmoonbitlang/yacc@0.7.23(latest release) still emits it, so bumping the pin does not help. Once a yacc release emitsList([])(fix warnings and bump version moonyacc#87 is in flight), bump the pin in the fourmoon.pkgrules and drop-20. Until then the suppression also hides deprecations in the hand-written files of those three packages.moon.pkglines (this PR).CI status: every step passes on stable and nightly except the last one, "test openseek corpus", which is red for a reason outside this PR:
moonbitlang/openseek@main(8647dcb) now contains range patterns writtena..<=b(what the new formatter emits fora..=b), and the parser rejects them ("Unexpected token ..<=", 80 corpus checks). That needs..<=support in the parser itself and will fail the same way on master and on #207.Verification (moon 0.1.20261012, same commands as the stable workflow):
moon -C lexer checkok,moon check --deny-warnclean,moon info --target allwithout diff,moon fmtwithout diff,moon test --target allwasm 2907, wasm-gc 2904, js 2904, native 2909, all passing (same counts as before the change). The openseek corpus test was left to CI.Note: source using
Int32/UInt32needs moon 0.1.20261012 or newer.