Repository navigation
fix(actions): group "(shard N)" jobs into one arc-job-report row - #383
Merged
Merged
Conversation
Shards were only recognised as "<name> - shard N", and name() strips a "(...)" suffix before that check. Monorepo-typescript's "Test (shard N)" jobs therefore collapsed into one jobs-table row together with the separate "Test" gate job, linking only the slowest shard, and got one suggestion row each: PR 11599's comment listed 11 runner changes, 7 of them identical "Test" rows. Both formats now group into a "Test · shards 1 2 ..." row in both tables. Suggestion rows group shards per change and reason, with the highest memory and CPU and the fewest runs among them, and the 💡 count is the number of rows. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
JesperTerkelsen
marked this pull request as ready for review
October 13, 2026 15:35
JesperTerkelsen
requested review from
tobias0106
and removed request for
a team
October 13, 2026 15:35
… name server names its shards "unit-tests (shard-N)", which the shard pattern did not match. Rows were also sorted by the full job name, which put a job like "Unit Tests (Fast Feedback)", shown as "Unit Tests", after the "Unit Tests · shards" row in service-ocpi's comment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…short name server's Integration tests workflow has two matrix jobs, "integration-tests (integration, app, identity, ...)" and "integration-tests (integration-services, ...)". Both were shown as "integration-tests", so the two rows could not be told apart. A job now keeps its short name only when no other job in the run shortens to the same one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…rmat One combined regex for "<name> - shard N", "<name> (shard N)" and "<name> (shard-N)" was hard to read and to extend; each format is now its own pattern, tried in order. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
cweinberger
approved these changes
Oct 13, 2026
sudheer-monta
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ARC job report now groups monorepo-typescript's
Test (shard N)jobs into one row in both tables.Shards were only recognised as
<name> - shard N, which is service-ocpi's format. monorepo-typescript usesTest (shard N)and server usesunit-tests (shard-N).name()also strips a(…)suffix before that check, so on https://github.com/monta-app/monorepo-typescript/pull/11599#issuecomment-6141491902:Testgate job showed as a single "Test · 4m 07s" row, linking only the slowest shard.Testrows.All three shard formats now group:
Test · shards **1** 2 3 … 8 | 3m 24s – 4m 07s, plusTest | 7son its own row.Jobs that aren't shards are grouped by their full name, so two jobs that differ only in a
(…)suffix keep separate rows. When two jobs would show the same short name, such as server's matrix jobsintegration-tests (integration, app, …)andintegration-tests (integration-services, …), both show their full name. Rows sort by their shown name, so service-ocpi'sUnit Tests (Fast Feedback), shown asUnit Tests, stays above theUnit Tests · shardsrow.Testing
(shard N)jobs next to a gate job with the bare name (both tables, shards grouped per change, the 💡 count), and(shard-N)shards together with the row order. A third covers matrix jobs that share a short name. All 15 tests pass (python3 -m unittest discover -s .github/actions/arc-job-report -p 'test_*.py').arc_job_report.py --dry-runon https://github.com/monta-app/monorepo-typescript/actions/runs/38420988227 (the run behind the comment above) rendersTest · shards 1–8and a separateTestgate row in the jobs table, and 5 suggestion rows includingTest · shards 4 5 6 | ⬇️ 8cpu-24gb → 4cpu-12gb | trial.--dry-runon server'sUnit testsrun https://github.com/monta-app/server/actions/runs/38415617446 (https://github.com/monta-app/server/pull/27724) rendersunit-tests · shards 1 2 **3** 4 5 6 7 8 | 3m 27s – 3m 58s. server doesn't run the report yet.--dry-runon service-ocpi's https://github.com/monta-app/service-ocpi/actions/runs/38421554371 renders the same jobs table as the posted comment https://github.com/monta-app/service-ocpi/pull/2725#issuecomment-6147409048.🤖 Generated with Claude Code