Repository navigation
feat(deploy): scope the ArgoCD wait to one Deployment [NOJIRA] - #380
Merged
Merged
Conversation
tobias0106
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
argocd-resource-nameinput todeploy-generic-v2.ymlanddeploy-kotlin-v2.yml, passed throughcomponent-deploy-v2.ymltoargocd-wait-sync's existingresource-name. The deploy wait then needs the expected revision,Synced, and that Deployment healthy, and it ignores the app's aggregate health.Degradedresource in the app fails the deploy on the first poll, even when the rollout itself is fine. In service-monta-factory run 38388140776 the Deployment wasHealthy, but two CronJobs whose last Job had failed made the appDegraded.