Repository navigation
feat(service-profile): add service-profile-name override [NOJIRA] - #378
Closed
tobias0106 wants to merge 1 commit into
Closed
tobias0106 wants to merge 1 commit into
tobias0106 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service-profile job names the ServiceProfile
<service-identifier>-<stage>.<service-identifier>-<stage>.svc.cluster.local. Linkerd only applies a profile whose name matches the real Service, so a service whose Kubernetes Service is named differently gets a profile Linkerd ignores. The OCPP processor is one:service-identifier: ocpp-main, but the Service isocpp-productioninocpp-production(andocpp-stagingon staging).Adds an optional
service-profile-nameinput todeploy-kotlin,deploy-kotlin-v2andcomponent-service-profile-kotlin. When set, the job writes it tometadata.nameon both new and existing profiles, so the name stays CI-managed instead of being hand-edited in kube-manifests. Leaving it empty keeps today's behaviour for every current caller.Tested the yq override locally (yq v4.53.2). Not run in CI yet.
Next: monta-app/service-ocpp#3200 sets
service-profile-name: ocpp-production.ocpp-production.svc.cluster.localfor the processor's production deploy.🤖 Generated with Claude Code