Skip to content

fix(terraform): fail on S3 errors other than a missing plan #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobias0106 merged 1 commit into from
Oct 8, 2026
Merged

fix(terraform): fail on S3 errors other than a missing plan #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/terraform-stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,17 @@ jobs:
AWS_REGION: ${{ steps.store.outputs.region || inputs.aws-region }}
run: |
set -eu
fetch() {
err=$(aws s3 cp --only-show-errors "$1" tfplan 2>&1) && return 0
case $err in *"(404)"*) return 1 ;; esac
echo "::error title=Could not read the plan::$err"
exit 1
}
uri="$PREFIX/${{ github.sha }}.tfplan"
if ! aws s3 cp --only-show-errors "$uri" tfplan 2>/dev/null; then
if ! fetch "$uri"; then
head=$(gh api "/repos/$REPO/commits/${{ github.sha }}/pulls" --jq '.[0].head.sha // empty')
uri="$PREFIX/$head.tfplan"
if [ -z "$head" ] || ! aws s3 cp --only-show-errors "$uri" tfplan; then
if [ -z "$head" ] || ! fetch "$uri"; then
echo "::error title=No reviewed plan::No saved plan for $STACK at ${{ github.sha }}. Dispatch the caller with command recover for this stack."
exit 1
fi
Expand Down