Skip to content

fix(lang): made marathi display properly (@agokule) - #8414

Open
agokule wants to merge 2 commits into
monkeytypegame:masterfrom
agokule:fix/marathi
Open

agokule wants to merge 2 commits into
monkeytypegame:masterfrom
agokule:fix/marathi

Conversation

@agokule

@agokule agokule commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Description

Currently, the Marathi language is not displayed properly on Monkeytype. This is because the "joiningScript" field of the json file is not there, so it is implicitly disabled. Marathi is written in the same alphabet as Hindi, so it should have the same setting as it.

So, in this PR, I fixed this issue by enabling the "joiningScript" field. I also added the "bcp47" field as well.

Checks

  • Adding quotes?
    • Make sure to follow the quotes documentation
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • (optional) Add theme css file to frontend/static/themes
    • Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the fonts documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Related:
#6395
#4174

Copilot AI lite review requested due to automatic review settings September 18, 2026 02:12
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Sep 18, 2026
@github-actions github-actions Bot added the waiting for review Pull requests that require a review before continuing label Sep 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Metadata matches Hindi conventions and existing consumers.

Pull request overview

Enables proper Marathi rendering and locale handling.

Changes:

  • Enables joining-script rendering.
  • Adds Marathi BCP 47 locale mr-IN.
File summaries
File Description
frontend/static/languages/marathi.json Adds Marathi metadata.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants