Repository navigation
Raise NoSuchFieldError for missing sort and cursor fields - #52
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Danger ReportNo issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #48.
Use the existing localized NoSuchFieldError when a criteria sort or saved cursor references a field no longer defined on the model. Validate plain and Base64 cursor objects, including decoded saved Base64 cursors, while preserving MismatchedSortFieldsError for differing existing fields and allowing nil values in defined fields.
Add regression coverage and document the error behavior.
Validation
Full RSpec suite (214 examples) and RuboCop for changed Ruby files pass. Full rake stops on two pre-existing Gemfile lint offenses (extra spacing and gem ordering); no unrelated lint changes included.