Skip to content

fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover, french sort order mistranslation, ctrl+p opens print menu #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ceebug wants to merge 10 commits into from
Closed

fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover, french sort order mistranslation, ctrl+p opens print menu #7630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fb5015c
Fix server card overflow on long messages and small screens
Ceebug Sep 20, 2026
369da9f
fix close button not be red hover
Ceebug Sep 20, 2026
a8be431
Merge branch 'modrinth:main' into main
Ceebug Sep 20, 2026
6ec1dc6
Merge remote-tracking branch 'origin/main' into fork/Ceebug/main
Prospector Sep 21, 2026
9df281c
Merge branch 'modrinth:main' into main
Ceebug Sep 22, 2026
bd6d946
fix(app/frontend): formatting
Ceebug Sep 22, 2026
8ba52f2
Merge branch 'main' of github.com:Ceebug/modrinth-code
Ceebug Sep 22, 2026
6c3fd76
Merge branch 'modrinth:main' into main
Ceebug Sep 22, 2026
73458dd
Fix descending sort order being 'Nom (A-Z)' in french when it should …
Ceebug Sep 22, 2026
553823b
Fix(app): Ctrl + P keybind works in app, bringing up the printer ui (…
Ceebug Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/app-frontend/src/components/ui/WindowControls.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<IconButton
type="quiet"
label="Close window"
class="relative expanded-button close-button"
class="relative expanded-button close-button hover:!bg-red focus-visible:!bg-red hover:!text-[var(--color-accent-contrast)]"
@click="handleClose"
>
<XIcon />
Expand Down
2 changes: 1 addition & 1 deletion apps/app-frontend/src/components/ui/world/RecentWorldsList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ onUnmounted(() => {
<style scoped lang="scss">
.grid-when-huge {
display: grid;
grid-template-columns: repeat(auto-fill, minmax(670px, 1fr));
grid-template-columns: repeat(auto-fill, minmax(min(670px, 100%), 1fr));
}

.jump-back-in-item {
Expand Down
27 changes: 17 additions & 10 deletions apps/app-frontend/src/components/ui/world/WorldItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,8 +492,8 @@ function openContextMenu(event: MouseEvent) {
no-shadow
class="!rounded-[14px]"
/>
<div class="flex flex-col justify-center gap-0.5 h-full">
<div class="flex items-center gap-1.5">
<div class="flex flex-col justify-center gap-0.5 h-full min-w-0">
<div class="flex items-center gap-1.5 min-w-0">
<div class="text-base text-contrast font-semibold truncate">
{{ getWorldDisplayName(world) }}
</div>
Expand Down Expand Up @@ -527,7 +527,7 @@ function openContextMenu(event: MouseEvent) {
</div>
<div
v-else-if="world.type === 'server'"
class="text-sm text-secondary flex items-center gap-1 font-semibold flex-nowrap whitespace-nowrap"
class="text-sm text-secondary flex items-center gap-1 font-semibold flex-nowrap whitespace-nowrap min-w-0 truncate"
>
<template v-if="refreshing">
<SpinnerIcon aria-hidden="true" class="animate-spin shrink-0" />
Expand All @@ -548,9 +548,9 @@ function openContextMenu(event: MouseEvent) {
stroke-width="3px"
class="shrink-0 smart-clickable:allow-pointer-events"
/>
<Tooltip :disabled="!hasPlayersTooltip">
<Tooltip :disabled="!hasPlayersTooltip" class="min-w-0 truncate">
<span
class="smart-clickable:allow-pointer-events"
class="smart-clickable:allow-pointer-events min-w-0 truncate"
:class="{ 'cursor-help': hasPlayersTooltip }"
>
{{
Expand All @@ -571,15 +571,15 @@ function openContextMenu(event: MouseEvent) {
</template>
<template v-else>
<NoSignalIcon aria-hidden="true" stroke-width="3px" class="shrink-0" />
{{ formatMessage(messages.offline) }}
<span class="truncate">{{ formatMessage(messages.offline) }}</span>
</template>
</div>
</div>
<div class="flex items-center gap-1.5 text-sm text-secondary">
<div class="flex items-center gap-1.5 text-sm text-secondary min-w-0">
<template v-if="instanceId">
<router-link
data-no-card-click
class="flex items-center gap-1 truncate hover:underline text-secondary smart-clickable:allow-pointer-events"
class="flex items-center gap-1 truncate hover:underline text-secondary smart-clickable:allow-pointer-events min-w-0"
:to="`/instance/${instanceId}`"
>
<Avatar
Expand Down Expand Up @@ -622,10 +622,16 @@ function openContextMenu(event: MouseEvent) {
class="motd-renderer font-normal font-minecraft line-clamp-2 text-secondary leading-5"
v-html="renderedMotd"
/>
<div v-else-if="!serverStatus" class="font-normal font-minecraft text-red leading-5">
<div
v-else-if="!serverStatus"
class="font-normal font-minecraft text-red leading-5 truncate max-w-full"
>
{{ formatMessage(messages.cantConnect) }}
</div>
<div v-else class="font-normal font-minecraft text-secondary leading-5">
<div
v-else
class="font-normal font-minecraft text-secondary leading-5 truncate max-w-full"
>
{{ formatMessage(messages.aMinecraftServer) }}
</div>
</template>
Expand Down Expand Up @@ -675,6 +681,7 @@ function openContextMenu(event: MouseEvent) {
<ContextMenu ref="cardOptions" :label="formatMessage(messages.worldActions)" />
</div>
</template>

<style scoped lang="scss">
.clickable-card:has([data-no-card-click]:hover) {
--hover-brightness: 1;
Expand Down
8 changes: 8 additions & 0 deletions packages/ui/src/composables/i18n-debug.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,14 @@ function setupKeyTooltip() {

function registerKeyboardShortcuts(panelOpen: Ref<boolean>, keyReveal: Ref<boolean>) {
useEventListener(document, 'keydown', (e: KeyboardEvent) => {
// Prevent the browser/app print dialog from opening with Ctrl+P / Cmd+P
if (e.ctrlKey || e.metaKey) {
if (e.code === 'KeyP') {
e.preventDefault()
return
}
}

// Use Cmd on macOS, Ctrl on other platforms
const mod = e.metaKey || e.ctrlKey
if (!mod || !e.shiftKey) return
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/locales/fr-FR/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@
"defaultMessage": "Nom (A-Z)"
},
"content.page-layout.sort.alphabetical-descending": {
"defaultMessage": "Nom (A-Z)"
"defaultMessage": "Nom (Z-A)"
},
"content.page-layout.sort.date-added-newest": {
"defaultMessage": "Plus récent en premier"
Expand Down