Skip to content

refactor(app): move out settings from feature flags - #7619

Merged
mergify[bot] merged 1 commit into
mainfrom
cal/fix-settings-as-feature-flags-bad
Sep 23, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
cal/fix-settings-as-feature-flags-bad

Conversation

@IMB11

@IMB11 IMB11 commented Sep 18, 2026

Copy link
Copy Markdown
Member
  • Some settings were feature flags when they should have been in the app db

@IMB11
IMB11 requested a review from a team September 18, 2026 15:44
@IMB11 IMB11 added app Relates to Modrinth App backend Involves work from the backend team frontend Involves work from the frontend team labels Sep 18, 2026
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Note

This changelog has been baked. Any further edits will not be reflected.

Pull request changelog

App

Added

Changed

  • Changed how some app settings are stored.
  • Added a setting to refocus Modrinth App when Minecraft closes - this is disabled by default.

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@IMB11

IMB11 commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio rebase

@mergify

mergify Bot commented Sep 21, 2026

Copy link
Copy Markdown

rebase

✅ Branch has been successfully rebased

@IMB11
IMB11 force-pushed the cal/fix-settings-as-feature-flags-bad branch from 11d54d3 to 624b22a Compare September 21, 2026 10:20
@IMB11

IMB11 commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio rebase

@mergify

mergify Bot commented Sep 21, 2026

Copy link
Copy Markdown

rebase

✅ Branch has been successfully rebased

@IMB11
IMB11 force-pushed the cal/fix-settings-as-feature-flags-bad branch from 624b22a to a246e97 Compare September 21, 2026 13:22
@mergify

mergify Bot commented Sep 22, 2026

Copy link
Copy Markdown

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Sep 23, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 27 minutes 2 seconds in the queue, including 26 minutes 35 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Sep 23, 2026
@mergify
mergify Bot merged commit dfadf78 into main Sep 23, 2026
10 checks passed
@mergify
mergify Bot deleted the cal/fix-settings-as-feature-flags-bad branch September 23, 2026 09:16
@mergify mergify Bot removed the queued label Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app Relates to Modrinth App backend Involves work from the backend team frontend Involves work from the frontend team

Development

Successfully merging this pull request may close these issues.

2 participants