Skip to content

fix(app/backend): old instances with '.' or ' ' ID endings break - #7617

Merged
IMB11 merged 1 commit into
mainfrom
cal/fix-instance-paths-before-validation
Sep 23, 2026
Merged

IMB11 merged 1 commit into
mainfrom
cal/fix-instance-paths-before-validation

Conversation

@IMB11

@IMB11 IMB11 commented Sep 18, 2026

Copy link
Copy Markdown
Member

No description provided.

@IMB11
IMB11 requested a review from a team September 18, 2026 14:27
@IMB11 IMB11 added app Relates to Modrinth App backend Involves work from the backend team labels Sep 18, 2026
@IMB11 IMB11 changed the title fix(app/backend): old instances with '.' or ' ' endings break fix(app/backend): old instances with '.' or ' ' ID endings break Sep 18, 2026
@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Note

This changelog has been baked. Any further edits will not be reflected.

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

  • Fixed "Instance not found" issue with super old pre-0.9.0 instances with folder naming that isn't allowed now.

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@IMB11
IMB11 marked this pull request as draft September 18, 2026 14:27
@IMB11
IMB11 marked this pull request as ready for review September 22, 2026 11:54
@mergify

mergify Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 27 minutes 9 seconds in the queue, with no time running CI.

Waiting for any of
  • check-neutral = Lint and Test
  • check-skipped = Lint and Test
  • check-success = Lint and Test
All conditions

Reason

Pull request #7617 has been merged manually at *0cd325e70a26d27963c42658e54aa0fb64adaa61*

Hint

You were too fast!

Tick the box to put this pull request back in the merge queue (same as @mergifyio queue).

  • Requeue this pull request

@mergify mergify Bot added the queued label Sep 23, 2026
@IMB11
IMB11 merged commit 0cd325e into main Sep 23, 2026
9 checks passed
@IMB11
IMB11 deleted the cal/fix-instance-paths-before-validation branch September 23, 2026 09:19
@mergify

mergify Bot commented Sep 23, 2026

Copy link
Copy Markdown

queue

☑️ The pull request has been merged manually

Details

The pull request has been merged manually at 0cd325e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app Relates to Modrinth App backend Involves work from the backend team

Development

Successfully merging this pull request may close these issues.

2 participants