Conversation
Contributor
|
Note This changelog has been merged into the changelog for #7467 Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
tdgao
added this pull request to stack #7468
September 11, 2026 22:32
Contributor
Frontend previewsLast deployed commit is 764b24ff389e241d33dcdb1afd1e1e7b4dd9104a Persistent
Latest commit
|
Contributor
Author
|
/deploy |
Member
|
🎉 Deployed |
tdgao
marked this pull request as ready for review
September 14, 2026 05:49
tdgao
marked this pull request as draft
September 14, 2026 05:50
tdgao
force-pushed
the
truman/better-external-link-validation
branch
from
September 14, 2026 19:02
441c71c to
882a403
Compare
tdgao
marked this pull request as ready for review
September 14, 2026 21:22
tdgao
force-pushed
the
truman/better-external-link-validation
branch
from
September 15, 2026 01:13
e1f0d1f to
fa3c7c8
Compare
tdgao
force-pushed
the
truman/better-external-link-validation
branch
2 times, most recently
from
September 15, 2026 17:27
7542170 to
6eb0a40
Compare
aecsocket
requested changes
Sep 15, 2026
| } | ||
| } | ||
|
|
||
| pub fn validate_donation_platforms( |
Contributor
There was a problem hiding this comment.
this isn't technically the correct way to do this, you should be looking up link_platforms in the db and fetching the full set of dono platforms from there. but also, I want to redo the entire link platforms system anyway so it's fine
Contributor
Author
There was a problem hiding this comment.
Yea right now each platform's allowlist/validation logic is also explicitly defined for each platform type in code instead of db.
I'll leave it as is
tdgao
force-pushed
the
truman/better-external-link-validation
branch
from
September 15, 2026 19:29
20b8d19 to
126de52
Compare
aecsocket
approved these changes
Sep 22, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend
details: { nags: ... }returned with save project validation errorFrontend