fix(deps): give the fastapi and faststream extras a lower bound - #252
Merged
Merged
Conversation
Both extras declared a bare name, so each resolved to a release predating the API the integration uses. Floors bisected against the suite. Closes #251
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #251.
Both integration extras declared a bare dependency name, so each admitted every release ever published:
Resolved at the bottom, each picked a release predating the API the integration uses — 5 collection errors:
The floors
Bisected against the suite:
fastapi>=0.115.3,faststream>=0.3.14.The faststream floor is older than it might look. It is the genuine minimum the suite passes at, so it is what the range should say — raising it further would be a policy choice about what to support rather than a correctness fix, and is better made deliberately than smuggled into this PR.
Verification
uv pip install --resolution lowest-direct ".[fastapi,faststream]"then the full suite:Lint clean. Normal resolution: 463 passed.
Nothing changes at the top of the range, so this is inert for anyone not installing at the lower bound.