Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions docs/adr/0006-docker-rejection-parity.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,14 @@ rule allows. The price is the reason the issue stayed open rather than something
service's typo now refuses the file for every target in it. Both documents moved out of a residual
catalogue and into `tests/conformance/corpus/`, where `assert_rule` -- which raises on exactly that
combination -- is what holds them closed, so the rule is hard everywhere with nothing suspended.
What remains open is a limitation rather than a residual: the drive-qualified *bind*
(`C:\data:/var`), since podman mounts that source through `--mount` and only the short `-v` spec
cannot spell it -- the long form already emits `--mount`, so the capability is reachable today and
only the short spelling is missing
([#111](https://github.com/modern-python/compose2pod/issues/111)).
One over-rejection is settled rather than open: the drive-qualified *bind* (`C:\data:/var`).
podman mounts that source through `--mount` and only the short `-v` spec cannot spell it, so the
capability is reachable today -- the long form emits exactly the invocation measured at exit 0,
and a `LIMITATIONS` row asserts it continuously. What was left was the ergonomic question, and
[#111](https://github.com/modern-python/compose2pod/issues/111) closed it as working as intended:
on Linux that spelling overwhelmingly means a Windows user pointed at a drive that is
not there, and falling back to `--mount` would bind a relative directory literally named
`C:\data`, surfacing much later as an empty mount instead of at once as an error naming the long
form. So the refusal is the tool, not a gap waiting to be filled. What would reopen it is a real
document wanting a colon in a short-form bind source on Linux, which is the evidence
[#86](https://github.com/modern-python/compose2pod/issues/86) never had.
4 changes: 3 additions & 1 deletion tests/conformance/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ def pytest_terminal_summary(terminalreporter: pytest.TerminalReporter) -> None:
terminalreporter.write_line(label)
terminalreporter.write_line(
f"{len(over_rejections)} over-rejection(s) -- catalogued limitations, not failures; "
"cross-check against the open limitation issues"
"each is ruled on in docs/adr/0003-the-shared-namespace-decides-key-classification.md "
"or docs/adr/0006-docker-rejection-parity.md, and one with no ruling there is the thing "
"to chase"
)


Expand Down
Loading