Skip to content

fix(conformance): specify application_type during dynamic client registration - #1177

Open
rea9r wants to merge 1 commit into
modelcontextprotocol:mainfrom
rea9r:fix/conformance-dcr-application-type
Open

rea9r wants to merge 1 commit into
modelcontextprotocol:mainfrom
rea9r:fix/conformance-dcr-application-type

Conversation

@rea9r

@rea9r rea9r commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Specify application_type: "native" when the conformance client registers itself through Dynamic Client Registration.

fixes #801

Motivation and Context

SEP-837, part of the 2026-07-28 spec, requires clients to specify an appropriate application_type during Dynamic Client Registration (Application Type and Redirect URI Constraints). Without it, OpenID Connect servers treat the client as web and may reject its http://localhost redirect URI.

The conformance client is a local command-line program that always redirects to the loopback URL http://localhost:3000/callback (CALLBACK_URL). The spec lists such clients as native applications, so it always registers as "native".

In the 2026-07-28 client suite, ten auth scenarios that register the client this way failed only on sep-837-application-type-present. With this change they pass. #1069 asks CI to require these suites to pass at 100%.

How Has This Been Tested?

CI runs conformance 0.1.16, which does not include the 2026-07-28 suites, so I ran the client suites locally with 0.2.0-alpha.12:

./gradlew :conformance-test:installDist
npx @modelcontextprotocol/conformance@0.2.0-alpha.12 client \
  --command "$PWD/conformance-test/build/install/conformance-test/bin/conformance-client" \
  --requirements 2026-07-28
  • 2026-07-28: the ten scenarios above fail before this change and pass after it. The other failures in this suite have different causes and are out of scope here.
  • 2025-11-25: all scored scenarios pass, as before.

The auth suite of 0.1.16, which CI runs, also passes, and so does ./gradlew :conformance-test:ktlintCheck.

Breaking Changes

None. Only the conformance client changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

The conformance client is the only code in main that registers a client, so this covers SEP-837 for the repository as it is today.

…stration

The conformance client registers itself through Dynamic Client Registration without application_type, which SEP-837 requires, so ten auth scenarios in the 2026-07-28 client suite fail.

Register as "native", since the client runs locally and redirects to a loopback URL.

fixes modelcontextprotocol#801

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement SEP-837: Update authorization spec to clarify client type requirements

1 participant