Repository navigation
fix: name speedPriority in its validation error - #1149
sarankumar1325 wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Nice catch — this fixes the mislabeled message and locks it in with a test, so it looks good to merge.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=946e69d3-54fa-4f0d-bd34-53ebd0201f7a
There was a problem hiding this comment.
Looks good — approving this one.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=c16367b8-7b95-4cd6-aeb7-8095b6b4fbf4
…message Signed-off-by: sarankumar1325 <120080287+sarankumar1325@users.noreply.github.com>
Fixes #1081
ModelPreferenceschecksspeedPriorityagainst the 0.0..1.0 range, but the error message namescostPriority(it was copied from the check above). A caller who passes a badspeedPriorityis told to fix the wrong field.Changes:
speedPrioritycheck now saysspeedPriority must be in 0.0 <= x <= 1.0 value range.should reject ModelPreferences with invalid prioritynow checks the message for all three priorities, not just the exception type. ThespeedPriorityassertion fails without the fix.Tests:
./gradlew :kotlin-sdk-core:jvmTest :kotlin-sdk-core:ktlintCheck :kotlin-sdk-core:detektpasses.