Repository navigation
Fix invalid sample counts in planar audio shrink - #1345
Merged
ddennedy merged 1 commit intoOct 16, 2026
Merged
Conversation
Signed-off-by: Dmitry Rantovov <rantovov5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mlt_audio_shrink()checks for negative or non-shrinking sample counts, but then falls through into a separate planar-dataif. With three channels and four samples per channel, asking for five samples causes a heap-buffer-overflow under AddressSanitizer; asking for -1 passes a negative size tomemmove. Both reproduce withmlt_audio_s32andmlt_audio_float.Make the planar move an
else ifso those requests leave the audio unchanged, as the existing guard intends. The data-driven regression covers negative, equal, larger, smaller, and zero counts in both formats, including channel contents after shrinking.Validation on macOS arm64: all 15 configured QtTest suites passed, including the 10 new audio cases; the same 10-case native probe passed against the ASan build (the four invalid-size cases failed before the change). The clang-format-14 check passed.