Repository navigation
Fix previous-key lookup on empty animations - #1344
Merged
ddennedy merged 1 commit intoOct 15, 2026
Merged
Conversation
Return an error instead of dereferencing a null node when the animation has no keyframes. Cover the C API and the C++ wrapper after removing the last keyframe. Signed-off-by: Dmitry Rantovov <rantovov5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mlt_animation_prev_key()dereferencesnodeafter searching even when the animation has no nodes. Both a newly allocated animation and one whose last keyframe was removed crash with SIGSEGV. Checknodebefore reading its frame so the function returns an error, as it does when no preceding keyframe exists.Add regressions for the C API on a new empty animation and the C++ API after removing the last keyframe. They also check that the output frame/key remains unchanged on failure. Both tests crash before the fix and pass afterwards; the existing previous/next-key tests pass in both versions.
Validation on macOS arm64:
ctest -R '^QtTest:' --output-on-failure).clang-format-checktarget passes with clang-format 14.0.6.AI-assisted change and validation.