Skip to content

[Version 3] Raspberry CPU support - #791

Merged
benoit-cty merged 2 commits into
masterfrom
cpu/arm_pi5
Oct 18, 2026
Merged

benoit-cty merged 2 commits into
masterfrom
cpu/arm_pi5

Conversation

@benoit-cty

Copy link
Copy Markdown
Contributor

Following #790 I've added the support for Rpi 4 and 5 CPU.

Source : https://gadgetversus.com/processor/broadcom-bcm2712-vs-broadcom-bcm2711/

@benoit-cty
benoit-cty changed the base branch from master to codecarbon_v3_rc February 28, 2025 07:26
@benoit-cty
benoit-cty changed the base branch from codecarbon_v3_rc to master April 14, 2025 18:18
@benoit-cty
benoit-cty changed the base branch from master to codecarbon_v3_rc April 14, 2025 18:19
@benoit-cty
benoit-cty requested a review from inimaz April 14, 2025 18:30
@benoit-cty benoit-cty changed the title Raspberry CPU support [Version 3] Raspberry CPU support Apr 14, 2025
Comment thread codecarbon/data/hardware/cpu_power.csv
@benoit-cty
benoit-cty changed the base branch from codecarbon_v3_rc to master June 22, 2025 08:42
@inimaz

inimaz commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

@benoit-cty you have some conflicts there, can you check? It would be interesting to merge this thanks!

@inimaz inimaz added enhancement New feature or request question Further information is requested labels Jul 30, 2026
@davidberenstein1957

Copy link
Copy Markdown
Collaborator

@benoit-cty heads-up: #797 covers the Raspberry Pi power reading through vcgencmd pmic_read_adc in 8 files with a test, and is mergeable. Worth checking whether the Pi part of this PR is still needed next to it, or whether this one can shrink to the datasets and notebooks.

@benoit-cty

Copy link
Copy Markdown
Contributor Author

Hi David,
It's complementary : cpu database is for fallback.
I will look to merge these 2 PR.

@benoit-cty
benoit-cty requested a review from a team as a code owner October 9, 2026 17:27
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.60%. Comparing base (9d62861) to head (39a3941).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #791   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          49       49           
  Lines        5339     5339           
=======================================
  Hits         4944     4944           
  Misses        395      395           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit-cty

Copy link
Copy Markdown
Contributor Author

Ready to merge. Can someone review this 2 lines PR ?

@davidberenstein1957 davidberenstein1957 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two rows in cpu_power.csv, placed in order, and the values are in line with the Pi 4 (BCM2711, about 6.5 to 7.5 W under load) and Pi 5 (BCM2712, about 12 W) board figures, so constant mode gets a sane number instead of the default. One thing I could not check from here: that cpuinfo on a Pi reports the model as Cortex-A72 / Cortex-A76 so the lookup actually hits. If you have seen that match on your Pi, good to merge.

@benoit-cty
benoit-cty merged commit 22b25a0 into master Oct 18, 2026
12 checks passed
@benoit-cty
benoit-cty deleted the cpu/arm_pi5 branch October 18, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request question Further information is requested size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants