fix: integrate GPU power when energy counter is absent

[davidberenstein1957]

Description

GPUDevice.delta now branches on the backend returning None for the cumulative energy counter. When it does, it computes Power.from_watts(self._get_power_usage()) and Energy.from_power_and_time(...) instead of comparing two identical counter readings, and logs a single warning per device so users know which method produced their numbers. The per-sample logger.warning in NvidiaGPUDevice._get_total_energy_consumption is demoted to debug, since the once-per-device warning now carries the signal.

Related Issue

Fixes #1316

Motivation and Context

On GPUs where NVML does not implement nvmlDeviceGetTotalEnergyConsumption (pre-Volta cards, many virtualised GPUs) the previous code returned last_energy unchanged, yielding energy_delta = 0 and power = 0 for the entire run, so a GPU-bound job silently reported only CPU + RAM. The fallback lives in the shared GPUDevice, so the AMD backend (which also returns None when no energy accumulator is present) is fixed by the same change. Power integration is less accurate than the counter, but it is the same approximation the CPU path already uses and is dramatically better than zero.

How Has This Been Tested?

tests/test_gpu_nvidia.py::TestGpu::test_gpu_without_energy_counter_falls_back_to_power patches the NVML energy query to raise and asserts 26 W / 29 W and 0.026 / 0.029 kWh over an hour. It fails on master (assert 0.0 == 26) and passes here. Three more tests in tests/test_gpu_nvidia.py cover the rest: test_gpu_energy_counter_recovery_does_not_double_count, test_gpu_without_power_usage_reports_zero_instead_of_raising and test_start_rebaselines_the_energy_counter. tests/test_gpu.py, tests/test_gpu_nvidia.py and tests/test_gpu_amd.py all pass (54 tests).

Screenshots (if appropriate):

N/A

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

AI Usage Disclosure

• 🟥 AI-vibecoded: You cannot explain the logic. Car analogy : the car drive by itself, you are outside it and just tell it where to go.
• 🟠 AI-generated: Car analogy : the car drive by itself, you are inside and give instructions.
• ⭐ AI-assisted. Car analogy : you drive the car, AI help you find your way.
• ♻️ No AI used. Car analogy : you drive the car.

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the docs/how-to/contributing.md document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.36%. Comparing base (eb46a83) to head (34e9ae2).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   92.15%   92.36%   +0.20%     
==========================================
  Files          49       49              
  Lines        5227     5341     +114     
==========================================
+ Hits         4817     4933     +116     
+ Misses        410      408       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[benoit-cty]

🤖 This review comment was written and posted by Claude Opus 5.5 (AI assistant), at the request of @benoit-cty. Findings were checked by reading the code and running tests locally (merged with current master where relevant), but please double-check before acting on them.

Verdict: ✅ Approve with nits

The bug is real. On master, _get_energy_kwh() returns last_energy when NVML/AMD exposes no energy counter, so every delta is 0. The fallback is correct:

• _get_power_usage() already returns W on both backends (NVML mW/1000; AMD average_socket_power).
• It works per device, so a mix of GPUs with and without counters is fine.
• Recovering from None to a real counter re-baselines without double counting, and it's tested.
• A failing power read now reports 0 W instead of raising.

54 GPU tests pass on this PR merged with master.

Nits / follow-ups:

1. This is a rectangle rule over a single instantaneous sample taken at the end of the interval. Pre-Volta NVML power is instantaneous, so a bursty workload over the default 15 s interval can be noticeably off. A follow-up could average the samples the monitor already takes each second over the interval.
2. On AMD dual-GCD devices, __post_init__ reads the counter before _known_zero_energy_counter is set, so the secondary GCD's first interval goes through the fallback. It's harmless because that GCD reports 0 W, but setting the flag first would be cleaner.
3. The description mentions 1 test; the diff adds 4. Please update it.
4. The branch is behind master; please update it.

[davidberenstein1957]

Made the changes in 19613ce: merged master, set static details before the first energy read (AMD dual-GCD flag), and updated the description to list all 4 tests.
Not done: averaging the monitor's per-second power samples over the interval, left as the suggested follow-up.