Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VRFPrivateKey,VRFPrivateKeyHolderandSchnorrkelPrivateKeyderivedDebug, which prints the full secret key material (the schnorrkel scalar and nonce in decimal). Since these types end up in the parsed command line options (e.g. a user-supplied--chain-genesis-staking-settingsVRF key), a single{:?}of the options at startup wrote the complete secret to the node log.ZeroizeOnDropdoes not address this: the schnorrkel secret already wipes itself on drop, butDebugstill prints it in full beforehand.Change
Debugfrom the derives ofVRFPrivateKey,VRFPrivateKeyHolder(crypto/src/vrf/mod.rs) andSchnorrkelPrivateKey(crypto/src/vrf/schnorrkel/mod.rs) and add hand-writtenDebugimpls that render<redacted>.Testing
cargo test -p crypto --lib(136 passed)./do_checks.sh