Repository navigation
Conversation
ianardee
requested review from
sebastianMindee
and
a balanced review from Copilot
October 12, 2026 08:32
There was a problem hiding this comment.
🟡 Changes recommended
Unchanged tests still import the deleted Barcode Reader package and invoke the removed Bank Check CLI command.
1 open finding
What changed in this PR
Removes retired V1 Barcode Reader and US Bank Check products, their CLI commands, tests, samples, and documentation. It also cleans up obsolete V1/V2 documentation references.
Changes:
- Removes retired product implementations and exports.
- Removes related CLI commands, tests, documentation, and samples.
- Corrects stale V2 API documentation references.
| File | Description |
|---|---|
tests/v1/product/us/bank_check/test_bank_check_v1.py |
Removes Bank Check tests. |
tests/v1/product/us/bank_check/__init__.py |
Removes test package marker. |
tests/v1/product/us/__init__.py |
Removes US test package marker. |
tests/v1/product/barcode_reader/test_barcode_reader_v1.py |
Removes Barcode Reader tests. |
tests/v1/product/barcode_reader/__init__.py |
Removes test package marker. |
mindee/v1/product/us/bank_check/bank_check_v1.py |
Removes Bank Check inference. |
mindee/v1/product/us/bank_check/bank_check_v1_page.py |
Removes page model. |
mindee/v1/product/us/bank_check/bank_check_v1_document.py |
Removes document model. |
mindee/v1/product/us/bank_check/__init__.py |
Removes product exports. |
mindee/v1/product/us/__init__.py |
Removes US exports. |
mindee/v1/product/barcode_reader/barcode_reader_v1.py |
Removes Barcode Reader inference. |
mindee/v1/product/barcode_reader/barcode_reader_v1_document.py |
Removes document model. |
mindee/v1/product/barcode_reader/__init__.py |
Removes product exports. |
mindee/v1/product/__init__.py |
Removes retired top-level exports. |
mindee/v1/commands/cli_products.py |
Removes retired CLI commands. |
docs/v2/product/extraction/params.rst |
Removes an invalid class reference. |
docs/v2/parsing/inference/index.rst |
Documents the renamed response class. |
docs/v2/file_operations.rst |
Removes obsolete class references. |
docs/v1/product/us/index.rst |
Removes the US product index. |
docs/v1/product/us/bank_check_v1.rst |
Removes Bank Check documentation. |
docs/v1/product/index.rst |
Removes the US index link. |
docs/v1/product/fr/id_card_v1.rst |
Removes V1 ID Card documentation. |
docs/v1/product/fr/bank_account_details_v1.rst |
Removes V1 bank-details documentation. |
docs/v1/product/barcode_reader_v1.rst |
Removes Barcode Reader documentation. |
docs/index.rst |
Removes an obsolete documentation page. |
docs/extras/code_samples/idcard_fr_v1.txt |
Removes the retired sample. |
docs/extras/code_samples/barcode_reader_v1.txt |
Removes the retired sample. |
docs/extras/code_samples/bank_check_v1.txt |
Removes the retired sample. |
docs/extras/code_samples/bank_account_details_v1.txt |
Removes the retired sample. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sebastianMindee
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes