Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The removals are consistent, the test refactor preserves existing assertions, and the remaining documentation concern is non-blocking.
0 open findings
What changed in this PR
Removes retired Barcode Reader V1 and US Bank Check V1 support from the SDK as an intentional breaking change.
Changes:
- Removes product implementations, exports, and CLI commands.
- Deletes related tests and samples, plus the Bank Account Details V1 sample.
- Splits V2 data-schema initialization tests into separate cases.
| File | Description |
|---|---|
| tests/v2/product/extraction/extractionParameters.spec.ts | Separates initialization test cases. |
| tests/v1/product/us/bankCheck/bankCheckV1.spec.ts | Removes Bank Check tests. |
| tests/v1/product/barcodeReader/barcodeReaderV1.spec.ts | Removes Barcode Reader tests. |
| src/v1/product/us/index.ts | Removes US product exports. |
| src/v1/product/us/bankCheck/index.ts | Removes Bank Check exports. |
| src/v1/product/us/bankCheck/bankCheckV1Page.ts | Removes page prediction model. |
| src/v1/product/us/bankCheck/bankCheckV1Document.ts | Removes document prediction model. |
| src/v1/product/us/bankCheck/bankCheckV1.ts | Removes Bank Check inference. |
| src/v1/product/index.ts | Removes retired product exports. |
| src/v1/product/cliProducts.ts | Removes retired CLI commands. |
| src/v1/product/barcodeReader/index.ts | Removes Barcode Reader exports. |
| src/v1/product/barcodeReader/barcodeReaderV1Document.ts | Removes document prediction model. |
| src/v1/product/barcodeReader/barcodeReaderV1.ts | Removes Barcode Reader inference. |
| docs/code_samples/barcode_reader_v1.txt | Removes Barcode Reader sample. |
| docs/code_samples/bank_check_v1.txt | Removes Bank Check sample. |
| docs/code_samples/bank_account_details_v1.txt | Removes Bank Account Details V1 sample. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
sebastianMindee
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes