Repository navigation
Conversation
ianardee
force-pushed
the
rag-crud
branch
16 times, most recently
from
October 8, 2026 16:21
c0a98e3 to
737505c
Compare
ianardee
marked this pull request as ready for review
October 8, 2026 16:28
There was a problem hiding this comment.
🟡 Changes recommended
Polling, numeric round-tripping, build configuration, mutable annotation state, and API compatibility issues remain unresolved.
6 open findings
What changed in this PR
Adds CRUD support for V2 extraction RAG documents, including annotation models, HTTP operations, polling, and tests.
Changes:
- Adds RAG document upload, retrieval, update, deletion, and polling APIs.
- Adds annotation models, parameters, and custom deserialization.
- Expands integration/unit tests and configures delomboked Javadocs.
| File | Description |
|---|---|
src/test/java/com/mindee/v2/product/SplitTest.java |
Renames test display label. |
src/test/java/com/mindee/v2/product/OcrTest.java |
Renames test display label. |
src/test/java/com/mindee/v2/product/extraction/RagDocumentsTest.java |
Tests RAG parameters and responses. |
src/test/java/com/mindee/v2/product/extraction/RagDocumentsIT.java |
Tests the RAG CRUD lifecycle. |
src/test/java/com/mindee/v2/product/extraction/ExtractionResponseTest.java |
Reorganizes extraction response tests. |
src/test/java/com/mindee/v2/product/extraction/ExtractionParametersTest.java |
Adds extraction parameter tests. |
src/test/java/com/mindee/v2/product/CropTest.java |
Renames test display label. |
src/test/java/com/mindee/v2/product/ClassificationTest.java |
Updates naming and local inference. |
src/test/java/com/mindee/v2/MindeeClientTest.java |
Extends the fake V2 API for RAG. |
src/test/java/com/mindee/v2/MindeeClientIT.java |
Refines integration-test naming. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/RagAnnotation.java |
Models an annotation payload. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/params/RagDocumentUploadParameters.java |
Adds extraction RAG upload parameters. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/params/RagDocumentAnnotationParameters.java |
Adds annotation update parameters. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/ExtractionRagAnnotationResponse.java |
Models extraction RAG responses. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/DynamicAnnotationFieldDeserializer.java |
Deserializes dynamic annotation fields. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/AnnotatedSimpleFieldDeserializer.java |
Deserializes simple annotation fields. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/AnnotatedSimpleField.java |
Models simple annotated values. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/AnnotatedObjectField.java |
Models annotated objects. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/AnnotatedListField.java |
Models annotated lists. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/AnnotatedFields.java |
Provides typed field lookup helpers. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/AnnotatedDynamicField.java |
Wraps dynamically typed annotations. |
src/main/java/com/mindee/v2/product/extraction/ragdocuments/AnnotatedBaseField.java |
Defines shared annotation configuration. |
src/main/java/com/mindee/v2/product/extraction/params/ExtractionParameters.java |
Revises builder documentation. |
src/main/java/com/mindee/v2/parsing/inference/field/InferenceFields.java |
Improves Javadoc links. |
src/main/java/com/mindee/v2/parsing/BaseRagAnnotationResponse.java |
Defines common RAG response properties. |
src/main/java/com/mindee/v2/MindeeClient.java |
Exposes RAG CRUD and polling operations. |
src/main/java/com/mindee/v2/http/MindeeHttpApiV2.java |
Implements RAG HTTP endpoints. |
src/main/java/com/mindee/v2/http/MindeeApiV2.java |
Extends the V2 API abstraction. |
src/main/java/com/mindee/v2/clientoptions/BaseSearchParameters.java |
Narrows generated accessors. |
src/main/java/com/mindee/v2/clientoptions/BaseRagDocumentUploadParameters.java |
Defines common upload parameters. |
src/main/java/com/mindee/v2/clientoptions/BaseProductParameters.java |
Adds constructor documentation. |
src/main/java/com/mindee/v2/clientoptions/BaseAnnotationParameters.java |
Defines common annotation parameters. |
src/main/java/com/mindee/exceptions/MindeeInputException.java |
Adds an invalid-input exception. |
pom.xml |
Adds delombok and Javadoc configuration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ianardee
force-pushed
the
rag-crud
branch
2 times, most recently
from
October 8, 2026 17:08
179d60a to
3953ace
Compare
There was a problem hiding this comment.
🟡 Changes recommended
It introduces breaking API behavior, inconsistent failed-state handling, and lossy numeric deserialization.
2 open findings
6 resolved since last review
🧠 Review effort: Balanced
sebastianMindee
requested changes
Oct 9, 2026
Co-authored-by: sebastianMindee <130448732+sebastianMindee@users.noreply.github.com>
…dParameters.java Co-authored-by: sebastianMindee <130448732+sebastianMindee@users.noreply.github.com>
Co-authored-by: sebastianMindee <130448732+sebastianMindee@users.noreply.github.com>
sebastianMindee
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes