Repository navigation
Move DataVis NITRO stories into the datavis submodule and add the DataVisNitroChat display mode #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Move DataVis NITRO stories into the datavis submodule and add the DataVisNitroChat display mode #520
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fb1d800
Move DataVis NITRO stories into the datavis submodule
tvenable-mie b6db0bc
Include datavis stories in catalog, lint, and format checks
tvenable-mie daa9aab
Repoint DataVis NITRO audit evidence links to the datavis submodule
tvenable-mie 4704e26
Address copilot admonition about comments being obviously incorrect.
tvenable-mie f169e5d
Address PR #520 review: absolute DataVis links, maintainer notes, sub…
tvenable-mie b4ad8ee
docs: link SuperChat and DataVis Chat; bump datavis for chat guidance
tvenable-mie 8f03bba
fix(storybook): link datavis submodule stories to mieweb/datavis
tvenable-mie 7df8fb1
chore(datavis): bump submodule for opt-in @mieweb/datavis/chat entry
tvenable-mie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Submodule story roots live in their own repos; GitHub can't browse into a gitlink. | ||
| const SUBMODULE_REPOS: Record<string, string> = { | ||
| 'packages/datavis/': 'mieweb/datavis', | ||
| }; | ||
|
|
||
| /** GitHub blob URL for a path relative to the ui repo root. */ | ||
| export function githubSourceUrl(repoPath: string): string { | ||
| const prefix = Object.keys(SUBMODULE_REPOS).find((p) => | ||
| repoPath.startsWith(p) | ||
| ); | ||
| const [repo, path] = prefix | ||
| ? [SUBMODULE_REPOS[prefix], repoPath.slice(prefix.length)] | ||
| : ['mieweb/ui', repoPath]; | ||
| return `https://github.com/${repo}/blob/main/${path | ||
| .split('/') | ||
| .map(encodeURIComponent) | ||
| .join('/')}`; | ||
| } | ||
|
|
||
| /** Repo-relative path of an absolute story file path, if it is in a known root. */ | ||
| export function repoRelativeStoryPath(fileName: string): string | null { | ||
| const roots = [...Object.keys(SUBMODULE_REPOS), 'src/']; | ||
| for (const root of roots) { | ||
| const index = fileName.indexOf(`/${root}`); | ||
| if (index >= 0) return fileName.slice(index + 1); | ||
| } | ||
| return null; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.