Repository navigation
Conversation
…ning A plan or wrap-up says what it is in its author's own words; the feed's guess only repeated it, and could be wrong. The label line keeps tickets, team and the scheduled-post note; the admin Session title keeps hours. - postLabelParts: no Plan/Wrap-up part; sessionPostIds removed. - buildTitle: no ⚠ no wrap-up; wrappedUpSessions removed. - postsToConversations: the sessionContext argument, which only fed those two, is gone, and so is the client's sessionUpdate field. Closes #856
🚀 Preview Deployment Ready
Preview auto-deletes when this PR is closed. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues requiring resolution for the Huddle presentation changes.
No open issues 🎉
What changed in this PR
Removes Huddle’s inferred Plan/Wrap-up labels and missing-wrap-up warning, addressing #856 while preserving the Clock page’s plan and wrap-up flow.
Changes:
- Removes labels and warnings while retaining ticket links, team names, scheduled-post notes, and admin session durations.
- Deletes supporting feed logic, the
sessionContextargument, and the client-facingsessionUpdatefield; backend session filtering remains unchanged. - Updates regression tests and adds a release note.
| File | Description |
|---|---|
src/pages/Huddle.tsx |
Removes the obsolete session-context argument from All search. |
src/lib/api.ts |
Removes sessionUpdate from the client post type. |
src/features/huddle/superChatFeed.ts |
Removes labels, warnings, and their supporting calculations. |
src/features/huddle/superChatFeed.test.ts |
Updates assertions for labels, titles, and retained metadata. |
release-notes/1.2.0.md |
Documents the Huddle presentation changes. |
meteor-backend/server/huddle.js |
Stops including sessionUpdate in enriched post responses. |
Review effort: Balanced
…move-plan-wrapup-labels Keeps sessionUpdate on HuddlePost and in enrichPost, which this branch had dropped with the labels: useSessionPost now reads it to skip updates.
…move-plan-wrapup-labels
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #856
Overview
Huddle tagged a session's main post Plan or Wrap-up, and admins saw ⚠ no wrap-up on a finished shift's title. People already write their plan as the first message when they clock in and write their wrap-up themselves, so the tags only repeated what the post said. They also relied on the feed guessing which post was the plan, which #854's review showed could go wrong. This removes them.
Changes
superChatFeed.tspostLabelPartsno longer adds Plan/Wrap-up. Ticket links, the team name (Personal) and the scheduled-post note stay on the label line.buildTitleno longer adds "⚠ no wrap-up". The admin Session title keeps its worked duration.sessionPostIds,wrappedUpSessions, and thesessionContextargument ofpostsToConversations, along with its one caller inHuddle.tsx(All's search).api.ts/huddle.js: the client-sidesessionUpdatefield added in fix(huddle): posts made while clocked in join the live session; Session shows shifts only #854 is gone, because only the label used it. The backend still stores the stamp and uses it inSESSION_POST_FILTER.release-notes/1.2.0.md.Not changed
SESSION_POST_SORT/SESSION_POST_FILTER).wrapUpAt, not the label.Testing
npm run lint,npm run typecheck,npm run format: clean.🤖 Generated with Claude Code