Skip to content

feat(huddle): drop the Plan and Wrap-up labels and the no wrap-up warning - #857

Open
Dharp02 wants to merge 4 commits into
fix/853-session-grouping-live-sessionfrom
feat/856-remove-plan-wrapup-labels
Open

Dharp02 wants to merge 4 commits into
fix/853-session-grouping-live-sessionfrom
feat/856-remove-plan-wrapup-labels

Conversation

@Dharp02

@Dharp02 Dharp02 commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Closes #856

Stacked on #854, which is stacked on #850. Retarget to main once those merge. It's built on #854 because both change the same lines in superChatFeed.ts, and it removes the sessionContext argument that #850's All search passes.

Overview

Huddle tagged a session's main post Plan or Wrap-up, and admins saw ⚠ no wrap-up on a finished shift's title. People already write their plan as the first message when they clock in and write their wrap-up themselves, so the tags only repeated what the post said. They also relied on the feed guessing which post was the plan, which #854's review showed could go wrong. This removes them.

Changes

  • superChatFeed.ts
    • postLabelParts no longer adds Plan/Wrap-up. Ticket links, the team name (Personal) and the scheduled-post note stay on the label line.
    • buildTitle no longer adds "⚠ no wrap-up". The admin Session title keeps its worked duration.
    • Removed the code that only fed those: sessionPostIds, wrappedUpSessions, and the sessionContext argument of postsToConversations, along with its one caller in Huddle.tsx (All's search).
  • api.ts / huddle.js: the client-side sessionUpdate field added in fix(huddle): posts made while clocked in join the live session; Session shows shifts only #854 is gone, because only the label used it. The backend still stores the stamp and uses it in SESSION_POST_FILTER.
  • Release note: "No more Plan and Wrap-up tags" in release-notes/1.2.0.md.

Not changed

  • The Clock page's plan and wrap-up flow, the "Require a plan to clock in" setting and the clock-out wrap-up gate.
  • How the backend picks a session's post (SESSION_POST_SORT / SESSION_POST_FILTER).
  • Searching "wrap-up" still finds wrap-up posts, because search reads wrapUpAt, not the label.

Testing

  • npm run lint, npm run typecheck, npm run format: clean.
  • Unit tests: 147/147.
    • The label tests are replaced by one that checks no post is labelled Plan or Wrap-up in any grouping.
    • The title test now checks admins still see hours and never a wrap-up warning.
  • E2E: all Huddle specs pass (84/84). No e2e test checked the labels.

🤖 Generated with Claude Code

…ning

A plan or wrap-up says what it is in its author's own words; the feed's
guess only repeated it, and could be wrong. The label line keeps tickets,
team and the scheduled-post note; the admin Session title keeps hours.

- postLabelParts: no Plan/Wrap-up part; sessionPostIds removed.
- buildTitle: no ⚠ no wrap-up; wrappedUpSessions removed.
- postsToConversations: the sessionContext argument, which only fed
  those two, is gone, and so is the client's sessionUpdate field.

Closes #856
Copilot AI balanced review requested due to automatic review settings November 6, 2026 22:53
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

🚀 Preview Deployment Ready

Service URL
App https://mieweb-timehuddle-feat-856-remove-plan-wrapup-labels.os.mieweb.org
API (Meteor) https://mieweb-timehuddle-feat-856-remove-plan-wrapup-labels-api.os.mieweb.org

Preview auto-deletes when this PR is closed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues requiring resolution for the Huddle presentation changes.

No open issues 🎉

What changed in this PR

Removes Huddle’s inferred Plan/Wrap-up labels and missing-wrap-up warning, addressing #856 while preserving the Clock page’s plan and wrap-up flow.

Changes:

  • Removes labels and warnings while retaining ticket links, team names, scheduled-post notes, and admin session durations.
  • Deletes supporting feed logic, the sessionContext argument, and the client-facing sessionUpdate field; backend session filtering remains unchanged.
  • Updates regression tests and adds a release note.
File Description
src/​pages/​Huddle.tsx Removes the obsolete session-context argument from All search.
src/​lib/​api.ts Removes sessionUpdate from the client post type.
src/​features/​huddle/​superChatFeed.ts Removes labels, warnings, and their supporting calculations.
src/​features/​huddle/​superChatFeed.test.ts Updates assertions for labels, titles, and retained metadata.
release-notes/​1.2.0.md Documents the Huddle presentation changes.
meteor-backend/​server/​huddle.js Stops including sessionUpdate in enriched post responses.

Review effort: Balanced

…move-plan-wrapup-labels

Keeps sessionUpdate on HuddlePost and in enrichPost, which this branch had
dropped with the labels: useSessionPost now reads it to skip updates.
Copilot AI balanced review requested due to automatic review settings November 10, 2026 17:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the Huddle label and warning removal.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 10, 2026 17:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block approval of the Huddle label and warning removal.

No open issues 🎉

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants