Repository navigation
Show Only Personal Posts in Huddle's Personal View - #852
Merged
Merged
Conversation
Personal used to gather the caller's posts from every team. It now reads like its own private team: only posts written in Personal show there, and a post written in a shared team stays in that team. - huddle.getMyPosts returns the caller's posts in their personal team only (empty when they have none yet). - Live clock tracking in Personal watches the personal team only. - Drop the per-post team label and the team-name search field, which only existed for the cross-team Personal view. - The empty Personal hint no longer says "any team". Closes #851
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new assertion fails on fresh databases or isolated runs because an empty Personal feed shows a starter conversation; create and load a Personal post before checking the team-token search.
1 open issue
What changed in this PR
Restricts Huddle’s Personal view to posts written in the caller’s personal team, addressing #851 without moving or deleting shared-team posts.
Changes:
- Limits Personal feed queries and live clock tracking to the personal team.
- Removes cross-team labels and search fields, and updates empty-state text.
- Updates unit, integration, and end-to-end coverage and adds a release note.
| File | Description |
|---|---|
tests/e2e/huddle/inbox-filters.spec.ts |
Checks isolation between Personal and shared-team posts. |
src/pages/Huddle.tsx |
Narrows live clock scope and removes team-name lookup. |
src/lib/api.ts |
Updates the Personal feed API comment. |
src/features/huddle/superChatFeed.ts |
Removes team labels and search fields; updates the Personal hint. |
src/features/huddle/superChatFeed.test.ts |
Adjusts label and empty-state tests. |
release-notes/1.2.0.md |
Documents the narrower Personal view. |
meteor-backend/tests/huddle-post-rest.test.ts |
Tests personal-team filtering and missing-team behavior. |
meteor-backend/server/main.js |
Updates the exposed method description. |
meteor-backend/server/huddle.js |
Restricts huddle.getMyPosts to the caller’s personal team. |
Review effort: Balanced
An empty Personal feed shows the starter conversation whatever the search, so counting search results failed on a fresh database or an isolated run. Post in Personal first, then check today's Personal thread doesn't hold the team post; clear the team search before switching, since it carries over and would hide Personal's message box.
…y-posts # Conflicts: # release-notes/1.2.0.md # src/pages/Huddle.tsx
🗑️ Preview Environment Cleaned UpThe preview container for this PR has been deleted. |
SarkarShubhdeep
approved these changes
Nov 6, 2026
SarkarShubhdeep
left a comment
SarkarShubhdeep
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks!
Dharp02
added a commit
that referenced
this pull request
Nov 11, 2026
Resolve conflicts with #852 (Personal shows only Personal posts): drop the team name from search and from All's search path too, keep All's date terms and Session's shift-only hint, and keep both release-note sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #851
Overview
Huddle's Personal view showed two things together: posts written in Personal (a private team whose only member is you), and your own posts from every team you belong to. People expect Personal to be a private space, so seeing team posts there was confusing. Personal now shows only what was written in Personal, so it reads like its own team.
Changes
huddle.getMyPosts(meteor-backend/server/huddle.js) returns the caller's posts in their personal team only, and an empty page when they don't have one yet. The method's description inmain.jsis updated to match.Huddle.tsxliveTeamIdsreusespostingTeamId).getTeamNamelookup is removed, along with comments that described Personal as cross-team.superChatFeed.ts: the per-post team label and the team-name search field only existed for the cross-team Personal view, so thegetTeamName/teamNameparameters are gone. The empty Personal hint now says "You haven't posted in Personal…" instead of "…in any team…".release-notes/1.2.0.md, which isn't tagged yet.Nothing is moved or deleted: team posts stay in their teams.
Testing
npm run lint,npm run typecheck,npm run format: cleanhuddle-post-rest.test.ts): thehuddle.getMyPoststests now use the caller's real personal team (created throughteams.ensurePersonal). Two new checks: the caller's own shared-team posts are left out, and a caller with no personal team gets an empty page. All 8 pass.stores each supported format, keeps the text around it, and leaves the rest inline(inline images inhuddle.createPost). This PR doesn't touch that code; I haven't checked whether it also fails on main.inbox-filters.spec.tsnow checks both directions: a team post doesn't show in Personal, and a post written in Personal doesn't show in the team. All Huddle e2e specs pass (76/76), as do the realtime Huddle specs.Note for #850
#850 (the All grouping) passes
getTeamNametopostsToConversationsandsearchPosts. Whichever PR merges second needs a small rebase to drop that argument.🤖 Generated with Claude Code