Repository navigation
Fix single-line formatting for custom Event Log output - #237
Open
bob sira (bobsira) wants to merge 1 commit into
Open
bob sira (bobsira) wants to merge 1 commit into
bob sira (bobsira) wants to merge 1 commit into
Conversation
Honor eventFormatMultiLine=false by replacing CRLF, CR, and LF in custom event messages with spaces. Preserve multiline mode and other output formats, add regression coverage, and document the behavior. Addresses #200.
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped fix matches the reported issue, includes targeted regression coverage, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Fixes #200 by making custom Event Log output honor eventFormatMultiLine: false, while preserving multiline behavior and leaving other output formats and log sources unchanged.
Changes:
- Replace each CRLF, CR, or LF message line break with one space before custom formatting.
- Add single-line and multiline regression tests covering eight message shapes.
- Document custom output’s single-line behavior.
| File | Description |
|---|---|
| LogMonitor/src/LogMonitor/EventMonitor.cpp | Normalize message line breaks for custom single-line output. |
| LogMonitor/LogMonitorTests/EventMonitorTests.cpp | Cover line endings, blank lines, literal escapes, and tabs in both modes. |
| LogMonitor/docs/README.md | Clarify newline replacement for custom output. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #200.
Custom Event Log output did not honor
eventFormatMultiLine: false. Replace each CRLF, CR, or LF line break in the event message with one space before applying the custom format.Validation