Skip to content

eng: raise optional VSCE peer minimum to 4.1.1 - #2435

Merged
Brandon Waterloo (bwateratmsft) merged 1 commit into
mainfrom
bwateratmsft-azure-tools-vsce-4-1-1
Nov 20, 2026
Merged

Brandon Waterloo (bwateratmsft) merged 1 commit into
mainfrom
bwateratmsft-azure-tools-vsce-4-1-1

Conversation

@bwateratmsft

Copy link
Copy Markdown
Contributor

🤖

Fixes: N/A (requested dependency update; no linked issue).

Raise eng's optional @vscode/vsce peer minimum from ^4.0.0 to ^4.1.1, preserving optional metadata and synchronizing its npm lockfile. Audited all eight packages; no others directly manage VSCE. Leave published dependency metadata and latest-auto-install pipelines unchanged.

Before: Screenshots are not applicable (dependency metadata only); eng accepted VSCE versions below 4.1.1.

After: Screenshots are not applicable; eng requires ^4.1.1 when the optional VSCE peer is installed. VSCE 4.1.1 requires Node >=22, compatible with eng's existing >=22.17.0 requirement.

Validation from eng:

  • npm install --package-lock-only --ignore-scripts --no-audit --no-fund — passed; only the root peer range changed.
  • npm ci --no-audit --no-fund — passed; VSCE remains uninstalled when absent.
  • npm run build — passed (ESM and CJS).
  • npm test — initially failed on the 2-second compiler-test startup timeout and cleanup lock.
  • npm test -- --timeout 20000 — passed: 41 passing, 5 platform skips.
  • npm run lint — passed.
  • npm pack --dry-run --json — passed: 73 files.

Additional Node assertions confirmed matching manifest/lock ranges, retained optional metadata, acceptance of 4.1.1, and rejection of 4.1.0; git diff --check passed. No repository review skill is present. No VSCE publishing operation was run.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 16:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the optional VSCE peer-minimum update.

No open issues 🎉

1 file not reviewed
  • eng/package-lock.json: Generated file
What changed in this PR

Raises eng’s optional @vscode/vsce peer minimum from ^4.0.0 to ^4.1.1, keeping VSCE installation consumer-owned.

Changes:

  • Updates the peer range in the manifest and synchronizes the lockfile.
  • Preserves optional metadata; published dependency metadata and pipeline installation behavior remain unchanged.
File Description
eng/​package.json Raises the optional VSCE peer requirement to ^4.1.1.
eng/​package-lock.json Synchronizes the root peer range with the manifest.

Review effort: Balanced

@bwateratmsft

Copy link
Copy Markdown
Contributor Author

🤖
Package-age gate: OK to merge on November 19, 2026 at 6:10:02 PM EST (23:10:02 UTC) or later, subject to required checks/approvals and unchanged audited dependencies.

Audited head: b3ebf54d239f9af317c2e3e6d863926b287ebaae. This PR only raises eng's optional @vscode/vsce peer minimum to ^4.1.1 in its manifest and root lockfile metadata; it adds or updates no resolved dependency versions and retains the optional metadata.

The npm publication timestamp for VSCE 4.1.1 is 2026-11-12T23:10:01.249Z, so it completes seven full days (168 hours) at 2026-11-19T23:10:01.249Z. The stated merge time includes a small margin. Re-audit if the dependency changes. This comment does not enable auto-merge or authorize bypassing checks or approvals.

@bwateratmsft
Brandon Waterloo (bwateratmsft) merged commit 8eaaf3f into main Nov 20, 2026
8 checks passed
@bwateratmsft
Brandon Waterloo (bwateratmsft) deleted the bwateratmsft-azure-tools-vsce-4-1-1 branch November 20, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants