fix(openapi3): emit valid deprecated parameter directives - #12042
Merged
Timothee Guerin (timotheeguerin) merged 1 commit intoSep 23, 2026
Conversation
microsoft-github-policy-service
Bot
added
emitter:openapi3
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Miko Parkkinen (Miko997)
September 23, 2026 16:27
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Fixes OpenAPI 3.2 conversion of deprecated parameters by emitting valid, message-bearing directives.
Changes:
- Corrects parameter directive formatting.
- Strengthens regression and compilation tests.
- Adds an OpenAPI 3 fix changelog entry.
| File | Description |
|---|---|
packages/openapi3/test/tsp-openapi3/ref-sibling-keywords.test.ts |
Adds regression and compilation validation. |
packages/openapi3/src/cli/actions/convert/generators/generate-operation.ts |
Corrects parameter directive rendering. |
.chronus/changes/fix-openapi3-deprecated-parameter-directive-2026-8-23-19-13-13.md |
Records the bug fix. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@microsoft-github-policy-service agree |
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Timothee Guerin (timotheeguerin)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10043.
Emit operation-parameter directives with their messages and place them on separate lines before decorators. Strengthen the existing regression with the OpenAPI 3.2 enum reference and default, and compile the generated TypeSpec.
Testing
pnpm --filter @typespec/openapi3 exec vitest run test/tsp-openapi3/ref-sibling-keywords.test.ts— fails before the fix, passes after.pnpm --filter @typespec/openapi3 testpnpm -r --filter "@typespec/openapi3..." buildpnpm buildpnpm test— 10,140 passed, 25 skipped.pnpm format:checkpnpm lintpnpm cspellLint passed after
pnpm clean; running it after a build also fails on unchanged upstream due to a compiler declaration-output collision. The full test run passed after recreating the ignoredpackages/monarch/tempdirectory, which the cached rebuild did not restore.