Repository navigation
feat(image-editor): add requireAssetName option and fix invalid name dismissal - #11777
Open
Dmitriy Antipov (THEb0nny) wants to merge 1 commit into
Open
Dmitriy Antipov (THEb0nny) wants to merge 1 commit into
Dmitriy Antipov (THEb0nny) wants to merge 1 commit into
Conversation
…dismissal - Add requireAssetName appTheme option to require an asset name before saving in the asset field editor - Prevent Done button from closing and silently discarding changes when an asset name is duplicate or invalid - Ensure Escape and close button cleanly discard changes without modifying the underlying block or file - Fix false invalid-character error when asset name input is empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireAssetNametarget option:requireAssetName?: booleanflag toappThemein target config (pxtarget.json).Fix dismissal on invalid/duplicate asset name:
onBlurfirst, which cleared the draft name and error state without updating the asset, silently dismissing the modal and losing changes.Clean cancellation on Escape / Close button:
Escapeor clicking✖inImageFieldEditornow explicitly cancels the edit session and leaves the underlying block / code unchanged.